Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mf workaround #1149
base: master
Are you sure you want to change the base?
Add Mf workaround #1149
Changes from 33 commits
254649c
63f898c
71cd3d8
60c3cb5
69e7bf2
5bf56fe
1c4fe31
66bd276
1791c28
9d473d3
afeb994
25b45d5
43932a3
8db0264
2cfd676
8b7a82a
b1b30ac
c21fb41
923f809
d3b3b61
dc204af
5bc1ecc
a14bba6
184a82f
efa743f
a0a1cd0
db1fc7b
d877dde
f1bb146
c055748
bdc3a58
71b7440
1e022ba
a9e3e1e
2bb2a27
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try
new Regedit(this.wine).open(regeditFile);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried that. It did not fix the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patch
is definitely wrong. See my argument above.What "error" do you get when you use
open
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats the thing. No error in terminal window in either
patch
oropen
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One parameter should work (the type can be
undefined
). I think it should beRegedit#patch
writes thepatchContent
to a file. So in your case, it tries to patch the registry with the string "${prefixDirectory}/mfWorkaround/mf-install-master/mf.reg" instead of the content of that file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case it cannot be a Phoenicis issue. Maybe something is wrong in the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plata just tried it on plain Wine and the whole .reg file is in the registry editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried other scripts that make use of
Regedit
? Do they work for you?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madoar yes they do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange. If Phoenicis uses the same command line as plain Wine, how can it be different...