Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build with updated ros container, clangd fixes #11

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

henrygerardmoore
Copy link
Collaborator

@henrygerardmoore henrygerardmoore commented Nov 26, 2024

This PR was synced to the ROS docker image, causing build to fail (as seen here too). This fixes that and some clang tidy issues and updates the markdown link checker to remove the pre-commit warning fixed here.

Comment on lines -61 to -63
args:
- "-c"
- "markdown-link-check-config.json"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@rlpratt12 rlpratt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, code builds again.

@henrygerardmoore henrygerardmoore enabled auto-merge (squash) November 26, 2024 22:53
@henrygerardmoore henrygerardmoore merged commit ef94df5 into main Nov 26, 2024
4 checks passed
@henrygerardmoore henrygerardmoore deleted the fix_build branch November 26, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants