Improve lab sim example objectives with story telling #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ites mobile_manipulation_config: revisit favorites
*colcon ignoring example behaviors
…ple_behaviors repository (#33) Co-authored-by: Nathan Brooks <[email protected]>
* fix(workspace): categories readded for lab_sim
MikeWrock
force-pushed
the
improve_lab_sim_examples
branch
from
973f81f to
15f1393
Compare
|
@MikeWrock can you retarget this to 7.0 please? I'd like to get it merged for that release. |
MikeWrock
reviewed
Dec 31, 2024
| @@ -52,6 +52,7 @@ | |||
| <disable_collisions link1="base_link_inertia" link2="shoulder_link" reason="Adjacent"/> | |||
| <disable_collisions link1="forearm_link" link2="upper_arm_link" reason="Adjacent"/> | |||
| <disable_collisions link1="forearm_link" link2="wrist_1_link" reason="Adjacent"/> | |||
| <disable_collisions link1="base_link_inertia" link2="upper_arm_link" reason="Adjacent"/> | |||
There was a problem hiding this comment.
I don't know why these links end up in collision after planning a waypoint, but this is my workaround
MikeWrock
reviewed
Dec 31, 2024
There was a problem hiding this comment.
@jeremydbronson please test
MikeWrock
reviewed
Dec 31, 2024
| @@ -1,16 +1,18 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <root BTCPP_format="4" main_tree_to_execute="Constrained Pick and Place"> | |||
| <root BTCPP_format="4" main_tree_to_execute="Move Beakers to Burners"> | |||
There was a problem hiding this comment.
@jeremydbronson please test this objective
|
@jeremydbronson can you test this against 7.0 by navigating to the example workspace and
|
jeremydbronson
previously approved these changes
Jan 1, 2025
jeremydbronson
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to cherry pick this to main - can you do that @MikeWrock ?