Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore docs demands in tests #1

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

johandahlberg
Copy link
Contributor

Description

This ignores linting the docstring in the tests, which I think is more trouble than it's worth.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested by running flake8 locally.

Copy link
Contributor

@fbdtemme fbdtemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also add the codes from pydoclint here:
https://jsh9.github.io/pydoclint/violation_codes.html

just adding DOC should cover everything

.flake8 Outdated Show resolved Hide resolved
Co-authored-by: Florian De Temmerman <[email protected]>
@johandahlberg johandahlberg force-pushed the chore/ignore-docs-demands-in-tests branch from 4994c54 to eb0105f Compare September 14, 2023 09:05
@johandahlberg johandahlberg force-pushed the chore/ignore-docs-demands-in-tests branch from eb0105f to 2ec7170 Compare September 14, 2023 09:06
@johandahlberg johandahlberg merged commit f4703eb into dev Sep 14, 2023
13 checks passed
@fbdtemme fbdtemme deleted the chore/ignore-docs-demands-in-tests branch September 15, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants