Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove adapterqc pbs flags #13

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Remove adapterqc pbs flags #13

merged 2 commits into from
Sep 29, 2023

Conversation

fbdtemme
Copy link
Contributor

Description

Remove unneeded --pbs1 and --pbs2 flags to adapterqc.
Customizig these values should happen through assay files.

Fixes: EXE-943

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

johandahlberg
johandahlberg approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@johandahlberg johandahlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbdtemme fbdtemme merged commit 45f49dd into dev Sep 29, 2023
@fbdtemme fbdtemme deleted the feature/remove-adapterqc-pbs-flags branch September 29, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johandahlberg johandahlberg johandahlberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbdtemme @johandahlberg