Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when there are fewer nodes than the number of dimensions in pmds layout #198

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

johandahlberg
Copy link
Contributor

@johandahlberg johandahlberg commented Nov 13, 2024

Description

Check up-front that the number of nodes is greater than the number of dimensions being requested in the pmds layout - if not give a clearer error message.

Fixes: exe-2061

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit test added and some manual testing.

PR checklist:

  • This comment contains a description of changes (with reason).
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If a new tool or package is included, I have updated poetry.lock, and cited it properly
  • I have checked my code and documentation and corrected any misspellings
  • I have documented any significant changes to the code in CHANGELOG.md

Copy link
Contributor

@ludvigla ludvigla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect. Great work!

@johandahlberg johandahlberg merged commit 433e234 into dev Nov 13, 2024
14 checks passed
@johandahlberg johandahlberg deleted the feature/exe-2061-resolve-k-value-bug branch November 13, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants