Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow tests on external action runners #22

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

fbdtemme
Copy link
Contributor

Description

Enable the workflow tests on private GH action runners again.
This also improves workflow test loading by not needing the yaml file to be in a python module (with __init__.py file in the directory).

Fixes: EXE-878

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manual testruns of the actions.

Copy link
Contributor

@johandahlberg johandahlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice use of duck typing on the NoModuleClass.

@fbdtemme fbdtemme merged commit 7305704 into dev Oct 13, 2023
13 checks passed
@fbdtemme fbdtemme deleted the fix/ci-integration-tests branch October 13, 2023 13:22
Copy link
Contributor

@ambarrio ambarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent this out late. Some questions I have.

@@ -0,0 +1 @@
External workflow test YAML files can be mounted or symlinked here and will be run as part of the workflow test suite.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would we use this? Basically writing a yaml like the test_full_D21.yaml? and putting it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants