correctness done.

src/prover/gkr.rs

@@ -1,6 +1,5 @@
 //! This module implements the core GKR IOP.
 
-
 use arith::{Field, SimdField};
 use ark_std::{end_timer, start_timer};
 

src/verifier.rs

@@ -179,10 +179,12 @@ fn sumcheck_verify_gkr_layer<C: GKRConfig>(
 
     for _i_var in 0..var_num {
         verified &= verify_sumcheck_step::<C>(proof, transcript, &mut sum, &mut rx);
+        // println!("x {} var, verified? {}", _i_var, verified);
     }
 
     for _i_var in 0..simd_var_num {
         verified &= verify_sumcheck_step::<C>(proof, transcript, &mut sum, &mut r_simdx);
+        // println!("x {} simd var, verified? {}", _i_var, verified);
     }
 
     let vx_claim = proof.get_next_and_step::<C::ChallengeField>();
@@ -204,18 +206,20 @@ fn sumcheck_verify_gkr_layer<C: GKRConfig>(
 
     for _i_var in 0..var_num {
         verified &= verify_sumcheck_step::<C>(proof, transcript, &mut sum, &mut ry);
+        // println!("y {} var, verified? {}", _i_var, verified);
     }
 
     for _i_var in 0..simd_var_num {
         verified &= verify_sumcheck_step::<C>(proof, transcript, &mut sum, &mut r_simdy);
+        // println!("y {} simd var, verified? {}", _i_var, verified);
     }
 
     let vy_claim = proof.get_next_and_step::<C::ChallengeField>();
     verified &= sum
         == vx_claim
             * vy_claim
             * eval_sparse_circuit_connect_poly(
-                &layer.mul, rz0, rz1, r_simd0, r_simd1, alpha, beta, &rx, &ry, r_simd0, r_simd1,
+                &layer.mul, rz0, rz1, r_simd0, r_simd1, alpha, beta, &rx, &ry, &r_simdx, &r_simdy,
             );
     transcript.append_challenge_f::<C>(&vy_claim);
     (verified, rx, ry, r_simdx, r_simdy, vx_claim, vy_claim)
@@ -362,6 +366,9 @@ impl<C: GKRConfig> Verifier<C> {
                 let v1 = commitment.verify(&rz0, &r_simd0, claimed_v0);
                 let v2 = commitment.verify(&rz1, &r_simd1, claimed_v1);
 
+                println!("Debug: v1 verified? {}", v1);
+                println!("Debug: v2 verified? {}", v2);
+
                 log::debug!("first commitment verification: {}", v1);
                 log::debug!("second commitment verification: {}", v2);
 

tests/gkr_correctness.rs

@@ -93,13 +93,6 @@ fn test_gkr_correctness_helper<C: GKRConfig>(config: &Config<C>) {
 
     let mut circuit = Circuit::<C>::load_circuit(circuit_path);
 
-    // debug codes
-    circuit.layers.resize(1, CircuitLayer::<C>::default());
-    circuit.layers[0].add.clear();
-    circuit.layers[0].mul.clear();
-    circuit.identify_rnd_coefs();
-    // debug code done
-
     println!("Circuit loaded.");
 
     circuit.set_random_input_for_test();