Add arabic translation
#150
Conversation
There was a problem hiding this comment.
Why did you copy the themes, colors arrays, splash screen, etc., files instead of just strings.xml? there isn't anything to translate in those other files. You could take reference from an existing translation, you only need to create strings.xml in the values-ar directory to add your translations.
|
Excuse my ignorance ! I'll update my PR as soon as I can ! |
|
@starry-shivam DONE ! |
| <string name="archive_screen_header">الأرشيف</string> | ||
| <string name="archive_empty_placeholder">لا توجد أهداف مؤرشفة حتى الآن.</string> | ||
|
|
||
| <!-- Rate Us Dialog --> |
There was a problem hiding this comment.
I don't see anything like this in the base english strings.xml. It seems the translations are not complete and are not in the same order as the base english strings either. This is the reason why the build was failing. Please do a complete translation when adding a new language; otherwise, this results in an inconsistent user experience. Also, maintain the order of sections of strings the same as in the base strings.xml file so it's easier to find, update, and add new strings in the future.
Please take a look at the base strings file here and translate accordingly.
There was a problem hiding this comment.
Excuse my ignorance! I'll do when I'll have some free time!
There was a problem hiding this comment.
Sure, there's no hurry :)
…ears#154) Commits: * Add CSV backend & seperate JSON and CSV logic from backup manager * Add frontend for selecting backup filetype & rewrite CSV converter --------- Signed-off-by: starry-shivam <[email protected]>
|
Hi! Just a reminder, are you up for working on your translations now? I'm planning to do a new release soon, so if they get added now, I can include them in the upcoming release. |
|
Closing this PR due to no response from author, if you ever feel like working on it again, feel free to re-open. |
Tanslation language
Arabic
Translation checklist