Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add frameworks to onboarding part 2 #21091

Merged

Conversation

Lior539
Copy link
Contributor

@Lior539 Lior539 commented Mar 21, 2024

Added more frameworks to onboarding:

  • Astro
  • Bubble
  • Framer
  • Laravel
  • Nuxt
  • Remix

How did you test this code?

Check all steps look good for ff, replays, analytics, and surveys install

@Lior539 Lior539 requested a review from raquelmsmith March 21, 2024 20:56
@@ -20,42 +20,79 @@ export const allSDKs: SDK[] = [
docsLink: 'https://posthog.com/docs/libraries/js',
},
{
Copy link
Contributor Author

@Lior539 Lior539 Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reordered this list to be alphabetical (except for web+snippet) so that it appears in order in the onboarding guide list

@Lior539 Lior539 force-pushed the add-frameworks-to-onboarding-part-2 branch from 5978d1e to a0f9b18 Compare March 21, 2024 20:59
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Size Change: 0 B

Total Size: 821 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 821 kB

compressed-size-action

* svelte

* missing export

* export

* webflow

* vue

* django

* flag code
@Lior539 Lior539 merged commit 33f30a5 into add-frameworks-to-onboarding Apr 2, 2024
55 of 69 checks passed
@Lior539 Lior539 deleted the add-frameworks-to-onboarding-part-2 branch April 2, 2024 12:37
Lior539 added a commit that referenced this pull request Apr 2, 2024
* astro

* add bubble

* framer

* laravel

* nuxt

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* add remix

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* Update frontend/src/scenes/onboarding/sdks/feature-flags/angular.tsx

* feat: Add frameworks to onboarding part 3 (#21158)

* svelte

* missing export

* export

* webflow

* vue

* django

* flag code

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Raquel Smith <[email protected]>
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (wasn't pushed!)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants