-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add frameworks to onboarding part 2 #21091
Merged
Lior539
merged 14 commits into
add-frameworks-to-onboarding
from
add-frameworks-to-onboarding-part-2
Apr 2, 2024
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f6bfb4e
astro
Lior539 4ba6950
add bubble
Lior539 d8ef2df
framer
Lior539 d7777eb
laravel
Lior539 a0f9b18
nuxt
Lior539 38c0b91
Update UI snapshots for `chromium` (1)
github-actions[bot] 72a8b2b
Update UI snapshots for `chromium` (2)
github-actions[bot] b3aa883
Update UI snapshots for `chromium` (2)
github-actions[bot] dd10c13
add remix
Lior539 06cc486
Update UI snapshots for `chromium` (1)
github-actions[bot] 36049a4
Update UI snapshots for `chromium` (2)
github-actions[bot] a0f61a1
Update UI snapshots for `chromium` (2)
github-actions[bot] 1d85d4e
Update frontend/src/scenes/onboarding/sdks/feature-flags/angular.tsx
raquelmsmith e27dbe1
feat: Add frameworks to onboarding part 3 (#21158)
Lior539 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+6.55 KB
(110%)
frontend/__snapshots__/scenes-other-onboarding--onboarding-sd-ks--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+6.53 KB
(110%)
frontend/__snapshots__/scenes-other-onboarding--onboarding-sd-ks--light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
frontend/src/scenes/onboarding/sdks/feature-flags/astro.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { SDKKey } from '~/types' | ||
|
||
import { SDKInstallAstroInstructions } from '../sdk-install-instructions/astro' | ||
import { FlagImplementationSnippet } from './flagImplementationSnippet' | ||
|
||
export function FeatureFlagsAstroInstructions(): JSX.Element { | ||
return ( | ||
<> | ||
<SDKInstallAstroInstructions /> | ||
<FlagImplementationSnippet sdkKey={SDKKey.JS_WEB} /> | ||
</> | ||
) | ||
} |
13 changes: 13 additions & 0 deletions
13
frontend/src/scenes/onboarding/sdks/feature-flags/bubble.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { SDKKey } from '~/types' | ||
|
||
import { SDKInstallBubbleInstructions } from '../sdk-install-instructions/bubble' | ||
import { FlagImplementationSnippet } from './flagImplementationSnippet' | ||
|
||
export function FeatureFlagsBubbleInstructions(): JSX.Element { | ||
return ( | ||
<> | ||
<SDKInstallBubbleInstructions /> | ||
<FlagImplementationSnippet sdkKey={SDKKey.JS_WEB} /> | ||
</> | ||
) | ||
} |
13 changes: 13 additions & 0 deletions
13
frontend/src/scenes/onboarding/sdks/feature-flags/django.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { SDKKey } from '~/types' | ||
|
||
import { SDKInstallDjangoInstructions } from '../sdk-install-instructions' | ||
import { FlagImplementationSnippet } from './flagImplementationSnippet' | ||
|
||
export function FeatureFlagsDjangoInstructions(): JSX.Element { | ||
return ( | ||
<> | ||
<SDKInstallDjangoInstructions /> | ||
<FlagImplementationSnippet sdkKey={SDKKey.PYTHON} /> | ||
</> | ||
) | ||
} |
13 changes: 13 additions & 0 deletions
13
frontend/src/scenes/onboarding/sdks/feature-flags/framer.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { SDKKey } from '~/types' | ||
|
||
import { SDKInstallFramerInstructions } from '../sdk-install-instructions/framer' | ||
import { FlagImplementationSnippet } from './flagImplementationSnippet' | ||
|
||
export function FeatureFlagsFramerInstructions(): JSX.Element { | ||
return ( | ||
<> | ||
<SDKInstallFramerInstructions /> | ||
<FlagImplementationSnippet sdkKey={SDKKey.JS_WEB} /> | ||
</> | ||
) | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reordered this list to be alphabetical (except for web+snippet) so that it appears in order in the onboarding guide list