-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(automations): resource support #305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkedwards
requested a deployment
to
Acceptance Tests
November 21, 2024 04:31
— with
GitHub Actions
Waiting
parkedwards
requested a deployment
to
Acceptance Tests
November 21, 2024 05:00
— with
GitHub Actions
Waiting
parkedwards
force-pushed
the
feat/automations-api-redux
branch
from
November 23, 2024 06:50
b1e23b4
to
b4d9cfa
Compare
parkedwards
requested a deployment
to
Acceptance Tests
November 23, 2024 06:50
— with
GitHub Actions
Waiting
parkedwards
requested a deployment
to
Acceptance Tests
November 23, 2024 23:58
— with
GitHub Actions
Waiting
parkedwards
temporarily deployed
to
Acceptance Tests
November 25, 2024 01:49
— with
GitHub Actions
Inactive
parkedwards
changed the title
feat(automations): add resource
feat(automations): resource support
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge one, great work - couple small comments
parkedwards
temporarily deployed
to
Acceptance Tests
November 25, 2024 15:55
— with
GitHub Actions
Inactive
mitchnielsen
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to replicate the testing notes using the example resource 👌🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/prefect/issue/PLA-576/tfp-automations-scaffold-resource-and-add-acceptance-tests
Documentation on Automations
This PR adds
prefect_automation
support at the resource levelAutomations are polymorphic, at two different levels - the
trigger
and theactions
. The general structure of the schema is:The resource logic got pretty length, so I've split them up into the following files:
automation_model.go
--> this is thetfsdk
-based struct representation of the TF config, in golangautomation_schema.go
--> this defines the HCL configuration schemaautomation_resource.go
--> this has the lifecycle hooks, as well as some lengthy helpers to parse and map the automation, trigger, and action objects both to and from the TF layerTesting
Build the provider locally at this branch
Navigate to the examples file
Add your provider configuration
And you'll see the Automations created