Add pc 1.21.1 data #925

extremeheat · 2024-10-14T10:31:13Z

No description provided.

rom1504 · 2024-10-14T22:03:48Z

data/dataPaths.json

@@ -1436,9 +1436,36 @@
      "materials": "pc/1.20.5",
      "language": "pc/1.20.5",
      "entities": "pc/1.20.5",
-      "protocol": "pc/1.20.5",
+      "protocol": "pc/1.21",


this seems wrong

rom1504 · 2024-10-14T22:04:28Z

data/dataPaths.json

+      "sounds": "pc/1.20.4",
+      "proto": "pc/latest"
+    },
+    "1.21": {


should we go straight to 1.21.1 ?

GroobleDierne · 2024-10-18T18:35:14Z

@extremeheat are you still working on this? I did some testing by connecting a nmp client using your protocol.json to a 1.21 server and some clientbound packets aren't processed successfully.
If it can be of any help, here are the errors I encountered:
~~When detonating a TNT next to the player~~ fixed

PartialReadError: Read error for undefined : Missing characters in string, found size is 230 expected size was 807
    at new ExtendableError (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/utils.js:63:13)
    at new PartialReadError (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/utils.js:70:5)
    at Object.string (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:100:15)
    at Object.packet_explosion (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:2026:89)
    at eval (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:4112:58)
    at packet (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:4203:9)
    at CompiledProtodef.read (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:70:12)
    at e.message (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:111:49)
    at tryCatch (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/utils.js:50:16)
    at CompiledProtodef.parsePacketBuffer (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:111:29)

~~When joining the server~~ Fixed in #927

PartialReadError: Read error for undefined : Missing characters in string, found size is 21766 expected size was 21779
    at new ExtendableError (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/utils.js:63:13)
    at new PartialReadError (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/utils.js:70:5)
    at Object.string (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:100:15)
    at eval (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:625:55)
    at Object.SlotComponent (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:729:9)
    at eval (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:748:49)
    at eval (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:753:15)
    at eval (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:771:13)
    at Object.Slot (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:773:9)
    at eval (eval at compile (/home/maceo/Documents/dev/node/node-minecraft-protocol/node_modules/protodef/src/compiler.js:262:12), <anonymous>:356:40

And player_chat and profileless_chat related errors that I fixed in #927

extremeheat · 2024-10-26T12:39:33Z

The packet_explosion was broken since 1.20.3, fixed

ChatTypes type was wrong, it's either an ID or encoded inline (and your proposed fix in PR is incorrect), just fixed.

rom1504 · 2024-10-26T12:49:48Z

PrismarineJS/mineflayer#3480 chat back at being broken after the change here

Should I undo PrismarineJS/prismarine-registry#42 ?

rom1504 · 2024-10-26T12:50:52Z

Trying

GroobleDierne · 2024-10-26T12:51:56Z

The packet_explosion was broken since 1.20.3, fixed

ChatTypes type was wrong, it's either an ID or encoded inline (and your proposed fix in PR is incorrect), just fixed.

lol I just fixed the packet_explosion in my pr too, I'm going to pull your changes then

GroobleDierne · 2024-10-26T12:55:00Z

data/pc/latest/proto.yml

+      _: soundId ?
+         if 0:
+            soundName: string
+            range?: f32


This is the same logic that is used for packet_entity_sound_effect, maybe a common type can be made to avoid duplication

rom1504 · 2024-10-26T12:59:49Z

PrismarineJS/mineflayer#3480 chat back at being broken after the change here

Should I undo PrismarineJS/prismarine-registry#42 ?

No same if not using the change at prismarine registry

Chat is timing out

We need another change

GroobleDierne · 2024-10-26T13:34:00Z

Also, wolf_variant metadata is broken

GroobleDierne · 2024-10-26T13:46:53Z

#927 is ready to be merged into pc1.21

GroobleDierne · 2024-10-26T16:00:19Z

Also, wolf_variant metadata is broken

wild_texture seems to work the same as soundId in packet_explosion, if I set its type to varint I get the numeric identifier of its texture + 1. However, the other fields seem to be optional/missing I'm not sure.

SuperGamerTron · 2024-10-26T18:17:04Z

PrismarineJS/mineflayer#3480 chat back at being broken after the change here
Should I undo PrismarineJS/prismarine-registry#42 ?

No same if not using the change at prismarine registry

Chat is timing out

We need another change

my bad, should've made a note

PrismarineJS/prismarine-registry#42 now requires PrismarineJS/minecraft-data#932

* 1.21: add blocks enchantments foods language materials & tints * Fix enchantment category * 1.20.5: fix enchantCategories * 1.21: Add items.json * Add update informations for foods.json * 1.21: Add recipes.json * 1.21: protocol.json fix vibration particle * 1.21.1: Add sounds.json

rom1504 · 2024-10-26T19:59:16Z

@GroobleDierne "pickaxe not upside-down recipe test" is failing, can you check it?

rom1504 · 2024-10-26T20:01:22Z

@extremeheat

packet explosion seems to have issues

packets 1.20.6v
play,ClientBound,packet_explosion:
TypeError: Cannot convert undefined or null to object
at Function.keys ()
at /home/runner/work/node-minecraft-protocol/node-minecraft-protocol/test/packetTest.js:128:16
at Array.forEach ()
at Object.container (test/packetTest.js:122:27)
at getValue (test/packetTest.js:266:34)
at testPacket (test/packetTest.js:339:75)
at Context. (test/packetTest.js:333:9)
at process.processImmediate (node:internal/timers:476:21)

https://github.com/PrismarineJS/node-minecraft-protocol/actions/runs/11534539661/job/32108689005?pr=1342

rom1504 · 2024-10-26T20:56:59Z

data/pc/1.20.3/proto.yml

-      explosion_sound_name: string
-      sound_range?: f32
+      soundId: varint
+      _: soundId ?


this is super weird; are you sure?

it means sounds id must be 0 or the packet is invalid since there is no default

going to add default: void

No default defaults to void anyway no?

no, no default means there is no default: other values are impossible and should crash

GroobleDierne · 2024-10-26T21:06:57Z

@GroobleDierne "pickaxe not upside-down recipe test" is failing, can you check it?

I'll look into that tomorrow

…ell with anon top level

rom1504 · 2024-10-26T21:28:41Z

so the problem was that missing items in recipes should be null; not -1
I fixed it with a replace; can you fix it in the extractor @GroobleDierne ?

GroobleDierne · 2024-10-26T21:31:32Z

so the problem was that missing items in recipes should be null; not -1
I fixed it with a replace; can you fix it in the extractor @GroobleDierne ?

Yep I also updated the sounds generator for 1.21 this afternoon, I'll upstream everything.

rom1504 · 2024-10-26T21:37:14Z

/makerelease

extremeheat added 2 commits October 14, 2024 10:30

Add pc 1.21 protocol data

6c0e144

fix

dbd79a6

rom1504 reviewed Oct 14, 2024

View reviewed changes

Update dataPaths.json

865eebe

GroobleDierne mentioned this pull request Oct 18, 2024

1.21 Support PrismarineJS/node-minecraft-protocol#1342

Merged

Merge branch 'master' into pc1.21

57f1c0d

GroobleDierne mentioned this pull request Oct 26, 2024

Support Minecraft PC 1.21.3 #929

Closed

extremeheat added 3 commits October 26, 2024 12:09

to 1.21.1

be90b6b

Fix packet_explosion

cebd74f

Fix ChatTypes

8142faf

Fix SlotComponentType missing repair_cost

4debf6c

GroobleDierne reviewed Oct 26, 2024

View reviewed changes

rom1504 changed the title ~~Add pc 1.21 protocol data~~ Add pc 1.21.1 data Oct 26, 2024

Merge branch 'master' into pc1.21

c45e279

rom1504 reviewed Oct 26, 2024

View reviewed changes

add default in packet explosion switch for sound id

5b9f5ea

rom1504 added 3 commits October 26, 2024 23:14

use empty container instead of void in packet explosion so it works w…

843269e

…ell with anon top level

also on 1.20.5

44ab383

recipes should have null not -1

7e27d23

rom1504 merged commit d56346a into master Oct 26, 2024
4 checks passed

rom1504 deleted the pc1.21 branch October 26, 2024 21:37

rom1504bot mentioned this pull request Oct 26, 2024

Release 3.78.0 #933

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pc 1.21.1 data #925

Add pc 1.21.1 data #925

extremeheat commented Oct 14, 2024

rom1504 Oct 14, 2024

rom1504 Oct 14, 2024

GroobleDierne commented Oct 18, 2024 •

edited

Loading

extremeheat commented Oct 26, 2024

rom1504 commented Oct 26, 2024

rom1504 commented Oct 26, 2024

GroobleDierne commented Oct 26, 2024 •

edited

Loading

GroobleDierne Oct 26, 2024

rom1504 commented Oct 26, 2024

GroobleDierne commented Oct 26, 2024

GroobleDierne commented Oct 26, 2024

GroobleDierne commented Oct 26, 2024

SuperGamerTron commented Oct 26, 2024

rom1504 commented Oct 26, 2024

rom1504 commented Oct 26, 2024

rom1504 Oct 26, 2024

rom1504 Oct 26, 2024

GroobleDierne Oct 26, 2024

rom1504 Oct 26, 2024

GroobleDierne commented Oct 26, 2024

rom1504 commented Oct 26, 2024

GroobleDierne commented Oct 26, 2024

rom1504 commented Oct 26, 2024

Add pc 1.21.1 data #925

Add pc 1.21.1 data #925

Conversation

extremeheat commented Oct 14, 2024

rom1504 Oct 14, 2024

Choose a reason for hiding this comment

rom1504 Oct 14, 2024

Choose a reason for hiding this comment

GroobleDierne commented Oct 18, 2024 • edited Loading

extremeheat commented Oct 26, 2024

rom1504 commented Oct 26, 2024

rom1504 commented Oct 26, 2024

GroobleDierne commented Oct 26, 2024 • edited Loading

GroobleDierne Oct 26, 2024

Choose a reason for hiding this comment

rom1504 commented Oct 26, 2024

GroobleDierne commented Oct 26, 2024

GroobleDierne commented Oct 26, 2024

GroobleDierne commented Oct 26, 2024

SuperGamerTron commented Oct 26, 2024

rom1504 commented Oct 26, 2024

rom1504 commented Oct 26, 2024

rom1504 Oct 26, 2024

Choose a reason for hiding this comment

rom1504 Oct 26, 2024

Choose a reason for hiding this comment

GroobleDierne Oct 26, 2024

Choose a reason for hiding this comment

rom1504 Oct 26, 2024

Choose a reason for hiding this comment

GroobleDierne commented Oct 26, 2024

rom1504 commented Oct 26, 2024

GroobleDierne commented Oct 26, 2024

rom1504 commented Oct 26, 2024

GroobleDierne commented Oct 18, 2024 •

edited

Loading

GroobleDierne commented Oct 26, 2024 •

edited

Loading