-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(rust.yml/jobs/clippy): integrate with GitHub Code Scanning #417
base: master
Are you sure you want to change the base?
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
I forgot it to install clippy-sarif in the release mode linting job 💀 |
Now let's trigger clippy. |
Now let's revert it! |
This reverts commit 74ec8e7.
It says fixed now. |
So, What does this do ? |
It adds a "review" that comments on each line that clippy screams at, instead of you having to go look at the CI logs for the clippy job. |
I don't think this is really needed, I think its more annoying that actually useful. People also don't really have to go into the CI logs. They can just see what CI failed and then fix it locally |
Description
See CCBlueX/LiquidBounce#4887, it's basically this but for detekt (because that's what LiquidBounce uses for linting their Kotlin part).
This PR pretty much just adds more QoL. Nothing really useful for anyone who isn't reviewing the code for PRs.
See https://docs.github.com/en/code-security/code-scanning/introduction-to-code-scanning/about-code-scanning#about-third-party-code-scanning-tools
Also, you can probably open up the results.sarif file in any JetBrains IDE (e.g. IntelliJ IDEA) with Server-side Analysis and see all linting errors.
Testing
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmt
cargo clippy