Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(rust.yml/jobs/clippy): integrate with GitHub Code Scanning #417

Closed
wants to merge 7 commits into from
Closed

ci(rust.yml/jobs/clippy): integrate with GitHub Code Scanning #417

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d603b1
ci(rust.yml/jobs/clippy): integrate with GitHub Advanced Security / G…
DataM0del Dec 26, 2024
e95e5ca
ci(rust.yml/jobs/clippy): upload the result file, even if the job fails
DataM0del Dec 26, 2024
a2ad0b5
ci(rust.yml/jobs/clippy): also upload the results when building in re…
DataM0del Dec 26, 2024
76f75c4
ci(rust.yml/jobs/clippy_release): install clippy-sarif
DataM0del Dec 26, 2024
74ec8e7
chore(pumpkin/src/main): add unused function to trigger clippy
DataM0del Dec 26, 2024
5c93912
revert: "chore(pumpkin/src/main): add unused function to trigger clippy"
DataM0del Dec 26, 2024
d0c4c16
Merge branch 'Snowiiii:master' into feat/code-scanning
DataM0del Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,14 @@ jobs:
steps:
- uses: actions/checkout@v4
- run: rustup update ${{ matrix.toolchain }} && rustup default ${{ matrix.toolchain }}
- run: cargo install clippy-sarif
- uses: Swatinem/rust-cache@v2
- run: cargo clippy --all-targets --all-features
- run: cargo clippy --all-targets --all-features --message-format=json | clippy-sarif | tee results.sarif
- name: Upload analysis results to GitHub
uses: github/codeql-action/upload-sarif@v3
if: success() || failure()
with:
sarif_file: results.sarif
build_and_test:
name: Build project and test
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -77,4 +83,10 @@ jobs:
- uses: actions/checkout@v4
- run: rustup update ${{ matrix.toolchain }} && rustup default ${{ matrix.toolchain }}
- uses: Swatinem/rust-cache@v2
- run: cargo clippy --release --all-targets --all-features
- run: cargo install clippy-sarif
- run: cargo clippy --release --all-targets --all-features --message-format=json | clippy-sarif | tee results.sarif
- name: Upload analysis results to GitHub
uses: github/codeql-action/upload-sarif@v3
if: success() || failure()
with:
sarif_file: results.sarif
Loading