Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused #[allow()]'s #69

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Removed unused #[allow()]'s #69

merged 2 commits into from
Sep 6, 2024

Conversation

DaniD3v
Copy link
Contributor

@DaniD3v DaniD3v commented Aug 31, 2024

title

@DaniD3v
Copy link
Contributor Author

DaniD3v commented Aug 31, 2024 •
edited
Loading

This only fails CI on stable. Works on my nightly.
I think they patched the broken lint.

Let's wait for 1.81 release which is in 4 days.

@Snowiiii
Copy link
Member

Snowiiii commented Sep 5, 2024

1.81 is out. still failing

@DaniD3v
Copy link
Contributor Author

DaniD3v commented Sep 6, 2024

I'm using the nightly toolchain so it might've been fixed in 1.82.
I'm just gonna remove the one case

I'll also replace the existing allows with expect.

@DaniD3v
Copy link
Contributor Author

DaniD3v commented Sep 6, 2024

expect was newly added in 1.81 and warns if an #[allow] hint is not necessary anymore.

@Snowiiii
Copy link
Member

Snowiiii commented Sep 6, 2024

Looks good. Thank you @DaniD3v

@Snowiiii Snowiiii merged commit 15cceb5 into Pumpkin-MC:master Sep 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniD3v @Snowiiii