Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tested GraalPy version in CI #4867

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

msimacek
Copy link
Contributor

No description provided.

@msimacek
Copy link
Contributor Author

Hi @davidhewitt, I'm trying to update the GraalPy version used in CI, as you requested in #4802. Can you please give me the CI full label to run it? Should I keep the old version in the matrix as well? Or should I change the minimal supported version in the docs?

@davidhewitt
Copy link
Member

What is your upstream support policy for making graalpy versions end of life? We should probably not drop support before you do.

@msimacek
Copy link
Contributor Author

GraalPy's EOL is either the EOL of the corresponding Graal version (the .0 versions are LTS) or the CPython version it implements, whichever comes first. So, 24.0 should EOL some time in 2026. I was just concerned about your CI usage, since the graalpy jobs tend to be more demanding. I'll keep both versions then.

@msimacek msimacek force-pushed the msimacek/graalpy-24.1 branch 4 times, most recently from 55af1eb to a06dcf9 Compare January 23, 2025 09:49
@msimacek msimacek force-pushed the msimacek/graalpy-24.1 branch from a06dcf9 to cefc8a4 Compare January 23, 2025 12:12
@msimacek msimacek force-pushed the msimacek/graalpy-24.1 branch from 7ca4921 to 17b78a7 Compare January 23, 2025 13:41
@msimacek
Copy link
Contributor Author

@davidhewitt, this should be ready. Unfortunately there is one test that fails because of a bug on our side. It is fixed already on our master, so it should work again in the next release. I skipped it on 24.1. Sorry about that, we should add pyo3 tests to our CI to prevent that from happening again.
Does this need a changelog item? It doesn't sound like an user facing change, so I think we could skip it.
There are 2 other CI failures - test-cross-compilation-windows and clippy/x86_64-unknown-linux-gnu/beta, that I believe I couldn't have caused.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Feb 7, 2025
@davidhewitt davidhewitt enabled auto-merge February 7, 2025 11:30
@davidhewitt davidhewitt added this pull request to the merge queue Feb 7, 2025
Merged via the queue into PyO3:main with commit 8ab39d2 Feb 7, 2025
83 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-build-full CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants