Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tested GraalPy version in CI #4867

Merged
merged 2 commits into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ jobs:
- name: Install nox
run: python -m pip install --upgrade pip && pip install nox

- if: inputs.python-version == 'graalpy24.1'
name: Install GraalPy virtualenv (only GraalPy 24.1)
run: python -m pip install 'git+https://github.com/oracle/graalpython#egg=graalpy_virtualenv_seeder&subdirectory=graalpy_virtualenv_seeder'

- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@master
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ jobs:
"pypy3.9",
"pypy3.10",
"graalpy24.0",
"graalpy24.1",
]
platform:
[
Expand Down
6 changes: 6 additions & 0 deletions pytests/tests/test_comparisons.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from typing import Type, Union

import sys
import pytest
from pyo3_pytests.comparisons import (
Eq,
Expand Down Expand Up @@ -28,6 +29,11 @@ def __ne__(self, other: Self) -> bool:
return NotImplemented


@pytest.mark.skipif(
sys.implementation.name == "graalpy"
and __graalpython__.get_graalvm_version().startswith("24.1"), # noqa: F821
reason="Bug in GraalPy 24.1",
)
@pytest.mark.parametrize(
"ty", (Eq, EqDerived, PyEq), ids=("rust", "rust-derived", "python")
)
Expand Down
Loading