Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reads to stdin and writes to stdout, batch execution of workflows #69
Reads to stdin and writes to stdout, batch execution of workflows #69
Changes from 15 commits
ff2fccc
144f037
d3e624c
67d1b15
d0cd15a
a72e01a
aab4a38
69d8b8c
2d3dfe9
91c8f3d
98cdef8
8559dc3
7fe89c6
f798249
48879db
206998f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran into this bug the other day where the graph didn't update after execution. The
execute
call returns the executed node for the front-end to then callworkflow.update_or_add_node()
to actually store thenode.data
attribute. Without this, I got complaints that predecessor data was missing when it's actually written to disk.Changing both if/else to include
executed_node = workflow_instance.<execute_method_here>...
and thenworkflow_instance.update_or_add_node(executed_node)
outside the if/else but within the for loop solves the issue. Come to think of it, we should probably update theexecute
method to have this behavior and update the execute endpoint as well (to avoid double-saving).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I've modified the code to do exactly what you suggested and seems to be working fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a modification that includes the dataframe output in sdtout. Didn't need to duplicate the exact functionality as ReadCsv I was able to print output = node_to_execute.execute(preceding_data, execution_options). I'm still not happy with the repeating of execute code in workflow, so will be refactoring this in the next PR.