Fix: Update front-end Dockerfile to pull in package-lock.json #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reelmatt
requested review from
cesarnda,
diegostruk,
reddigari,
matthew-t-smith and
cesaragv
cesaragv
approved these changes
Oct 8, 2020
diegostruk
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the Dockerfile for the front-end container would use
package.jsonto rebuild the dependency list. This includes some package changes since the last-tested commit/versions back in May. By adding thepackage-lock.jsonfile we can ensure the package versions match what we last tested/built on. This seems to solve the issues when runningdocker-compose up --buildto get the project up-and-running.