Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update front-end Dockerfile to pull in package-lock.json #95

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Fix: Update front-end Dockerfile to pull in package-lock.json #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c20ab68
fix: Add package-lock.json to front-end Dockerfile
hcat-pge Oct 8, 2020
52204ea
docs: Add note about URL where app is running to README
hcat-pge Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,12 @@ Note: there [is a known issue with `react-scripts` v3.4.1](https://github.com/fa
that may cause the front-end container to exit with code 0. If this happens,
you can add `-e CI=true` to the `docker-run` command above for the front-end.

NOTE: For development outside of Docker, change ./front-end/package.json from "proxy": "http://back-end:8000" to "http://localhost:8000" to work.
NOTE: For development outside of Docker, change `./front-end/package.json`
from `"proxy": "http://back-end:8000"` to `"proxy": http://localhost:8000"` to work.

After the Docker containers are started, and both front- and back-ends are running,
you can access the application by loading [http://localhost:3000/](http://localhost:3000/)
in your browser.

## Serve locally

Expand Down Expand Up @@ -140,6 +144,10 @@ npm install
npm start
```

By default, the `react-scripts` should open your default browser to the main
application page. If not, you can go to [http://localhost:3000/](http://localhost:3000/)
in your browser.

# CLI
PyWorkflow also provides a command-line interface to execute pre-built workflows
without the client or server running. The CLI is packaged in the `back-end`
Expand Down
1 change: 1 addition & 0 deletions front-end/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ FROM node:14-alpine
WORKDIR /visual-programming/front-end

COPY package.json .
COPY package-lock.json .

RUN npm install

Expand Down