-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add document build and deploy jobs #19
Conversation
37d8e11
to
15491da
Compare
@szabo137 Do you know, why the job fails? |
I will look into this. I assume some API change in |
Looks like this line of code causes the problem:
|
@szabo137 Looks like, the documentation references an error type, which does not exist. I didn't found anything in the QED projects and also not in the official documentation. |
It should be So I'd suggest renaming the |
Yes, you are right. We are a little bit inconsistent 😅 QEDprocesses.jl/src/interfaces/setup_interface.jl Lines 79 to 83 in 0074aa0
Nevertheless, I would fix the error in the documentation now and we do the possible renaming in an extra PR. |
15491da
to
43d5648
Compare
43d5648
to
a0d2ef9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to bother, merging!
solves #10
Copy of: QEDjl-project/QEDevents.jl#10