-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18/convert to package #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 21
Lines ? 996
Branches ? 0
======================================
Hits ? 0
Misses ? 996
Partials ? 0 ☔ View full report in Codecov by Sentry. |
AlexAxthelm
requested review from
cjyetman and
jdhoffa
and removed request for
cjyetman
December 2, 2024 17:37
I tested this PR in the following way:
# .env
analysis_output_dir: /PATH/TO/pacta_analysis_outputs
benchmarks_dir: /PATH/TO/pacta-data/2023Q4
dashboard_data_dir: /PATH/TO/pacta-dashboard-svelte/static/data
**Except for we still need to create a zip archive of the outputs, but that is tracked in #27 |
jdhoffa
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #21 (reworking to deal with code drift on
main
)Dockerize and convert to package structure.
Work yet to complete in other PRs:
pacta-dashboard-svelte
build artifacts (output working dashboard) (Integratepacta-dashboard-svelte
#33)Closes #29 by hard-copying relevant functions.
Closes #18