Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18/convert to package #30

Merged
merged 17 commits into from
Dec 2, 2024
Merged

18/convert to package #30

merged 17 commits into from
Dec 2, 2024

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Dec 2, 2024

Supersedes #21 (reworking to deal with code drift on main)

Dockerize and convert to package structure.

Work yet to complete in other PRs:

Closes #29 by hard-copying relevant functions.
Closes #18

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 996 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@74c30af). Learn more about missing BASE report.

Files with missing lines Patch % Lines
R/prepare_pacta_dashboard_data.R 0.00% 245 Missing ⚠️
R/prep_trajectory_alignment.R 0.00% 117 Missing ⚠️
R/prep_techmix_sector.R 0.00% 103 Missing ⚠️
R/prep_audit_table.R 0.00% 101 Missing ⚠️
R/prep_techexposure.R 0.00% 72 Missing ⚠️
R/prep_company_bubble.R 0.00% 59 Missing ⚠️
R/prep_exposure_stats.R 0.00% 57 Missing ⚠️
R/prep_key_bars_company.R 0.00% 47 Missing ⚠️
R/prep_emissions_trajectory.R 0.00% 39 Missing ⚠️
R/prep_key_bars_portfolio.R 0.00% 37 Missing ⚠️
... and 11 more
Additional details and impacted files
@@          Coverage Diff           @@
##             main     #30   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?      21           
  Lines           ?     996           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?     996           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexAxthelm AlexAxthelm requested review from cjyetman and jdhoffa and removed request for cjyetman December 2, 2024 17:37
@AlexAxthelm AlexAxthelm marked this pull request as ready for review December 2, 2024 17:37
@jdhoffa
Copy link
Member

jdhoffa commented Dec 2, 2024

I tested this PR in the following way:

  • I created a .env file as follows:
# .env
analysis_output_dir: /PATH/TO/pacta_analysis_outputs
benchmarks_dir: /PATH/TO/pacta-data/2023Q4
dashboard_data_dir: /PATH/TO/pacta-dashboard-svelte/static/data
  • I built and previewed the dashboard (different repo) with npm run build and npm run preview
  • I inspected everything and it all looks good! **

**Except for we still need to create a zip archive of the outputs, but that is tracked in #27

@AlexAxthelm AlexAxthelm merged commit d465509 into main Dec 2, 2024
20 checks passed
@jdhoffa jdhoffa deleted the 18/convert-to-package branch December 2, 2024 22:19
@AlexAxthelm AlexAxthelm mentioned this pull request Dec 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⬇️ remove pacta.portfolio.report dependency Implement Package Structure
2 participants