Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gemm_rewrite_test and add flaky_test_attempts option #23

Merged

Conversation

hsharsha
Copy link

No description provided.

pemeliya and others added 3 commits June 26, 2024 14:14
… combinations

Imported from GitHub PR openxla#13646

This PR openxla#12553 introduced some a regression bug by enabling CUDA-specific and ROCM-specific datatype combinations on both platforms.

@xla-rotation: could you please have a look ?
Copybara import of the project:

--
4d5b471 by Pavel Emeliyanenko <[email protected]>:

bugfixing supported datatypes

--
fd94e66 by Pavel Emeliyanenko <[email protected]>:

added AMD community CI subtest and commented out fix in gemm_rewrite for proof-of-concept

--
6082d3d by Pavel Emeliyanenko <[email protected]>:

reenabled fix and added gemm_rewriter subtest for f64/c64 dot ops

Merging this change closes openxla#13646

COPYBARA_INTEGRATE_REVIEW=openxla#13646 from ROCm:ci_gemm_rewriter_datatypes_fix 6082d3d
PiperOrigin-RevId: 642909288
Copy link

@i-chaochen i-chaochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@i-chaochen i-chaochen merged commit 5f7bb79 into rocm-jaxlib-v0.4.28-qa Jun 27, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants