Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gemm_rewrite_test and add flaky_test_attempts option #23

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Fix gemm_rewrite_test and add flaky_test_attempts option #23

merged 3 commits into from
Jun 27, 2024

Commits on Jun 26, 2024

  1. fixing gemm_rewriter subtest

    @pemeliya @hsharsha
    pemeliya authored and hsharsha committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c8286ce View commit details
    Browse the repository at this point in the history

  2. PR openxla#13646: [ROCM] gemm_rewriter: bugfixing supported datatypes… 

    … combinations

Imported from GitHub PR openxla#13646

This PR openxla#12553 introduced some a regression bug by enabling CUDA-specific and ROCM-specific datatype combinations on both platforms.

@xla-rotation: could you please have a look ?
Copybara import of the project:

--
4d5b471 by Pavel Emeliyanenko <[email protected]>:

bugfixing supported datatypes

--
fd94e66 by Pavel Emeliyanenko <[email protected]>:

added AMD community CI subtest and commented out fix in gemm_rewrite for proof-of-concept

--
6082d3d by Pavel Emeliyanenko <[email protected]>:

reenabled fix and added gemm_rewriter subtest for f64/c64 dot ops

Merging this change closes openxla#13646

COPYBARA_INTEGRATE_REVIEW=openxla#13646 from ROCm:ci_gemm_rewriter_datatypes_fix 6082d3d
PiperOrigin-RevId: 642909288
    @pemeliya @hsharsha
    pemeliya authored and hsharsha committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2471a91 View commit details
    Browse the repository at this point in the history

  3. Add flaky_test_attempts to run_xla.sh

    @hsharsha
    hsharsha committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    adf7949 View commit details
    Browse the repository at this point in the history