-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSPY-491 + RSPY-492 + RSPY-495 + RSPY-506: Update CADIP/AUXIP helm configuration #53
Conversation
aa7796e
to
2c50f19
Compare
a7f7cdf
to
4146a4a
Compare
05ea58d
to
be6dd9e
Compare
be6dd9e
to
82a1e15
Compare
4bd5539
to
179d63a
Compare
c9c92fc
to
76237e4
Compare
need_auth: true | ||
results_entry: responses | $ | ||
results_entry: $.value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vprivat-ads @Padeanu in rs-server we have 4 template session files:
- https://github.com/RS-PYTHON/rs-server/blob/fix/rspy491-cadip-search-fix-rebased-3-matthieu/services/cadip/config/cadip_ws_config.template.yaml
- https://github.com/RS-PYTHON/rs-server/blob/fix/rspy491-cadip-search-fix-rebased-3-matthieu/services/cadip/config/cadip_ws_config.template_session.yaml
- https://github.com/RS-PYTHON/rs-server/blob/fix/rspy491-cadip-search-fix-rebased-3-matthieu/services/cadip/config/cadip_ws_config_token_module.template.yaml
- https://github.com/RS-PYTHON/rs-server/blob/fix/rspy491-cadip-search-fix-rebased-3-matthieu/services/cadip/config/cadip_ws_config_token_module.template_session.yaml
Or see the two config files you edited before I have merged the templates into your branch:
- https://github.com/RS-PYTHON/rs-server/blob/d682b21d14402554c9320481c58929faacc34e17/services/cadip/config/cadip_ws_config.yaml#L635
- https://github.com/RS-PYTHON/rs-server/blob/d682b21d14402554c9320481c58929faacc34e17/services/cadip/config/cadip_ws_config_token_module.yaml
I don't know well the difference between the 4 template files, but Vincent in 2 of them you left results_entry: responses | $
and in the two others you changed to: results_entry: $.value
But here in rs-helm you used results_entry: $.value
in the 4 occurrences, so which one is right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgaucher-cs $.value
everywhere. I probably forgot some cases
sort: | ||
sort_by_tpl: '&$orderby={sort_param} {sort_order}' | ||
sort_param_mapping: | ||
startTimeFromAscendingNode: DownlinkStart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here @vprivat-ads, if I look at your two last changes in rs-server cadip config files:
- https://github.com/RS-PYTHON/rs-server/blob/d682b21d14402554c9320481c58929faacc34e17/services/cadip/config/cadip_ws_config.yaml
- https://github.com/RS-PYTHON/rs-server/blob/d682b21d14402554c9320481c58929faacc34e17/services/cadip/config/cadip_ws_config_token_module.yaml
The 3 fields:
startTimeFromAscendingNode: DownlinkStart
completionTimeFromAscendingNode: DownlinkStop
publicationDate: PublicationDate
are defined only for the _session stations. But in this helm chart, you defined them for all stations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the "non session" stations, only publicationDate should be added, there is no downlinkStart/Stop info at file level, it's only at session level
Quality Gate passedIssues Measures |
Changes to test connection to real CADIP and ADGS stations:
stationConfigFile
parameterTo use with RS-PYTHON/rs-server#687