Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSPY-491 + RSPY-492 + RSPY-495 + RSPY-506: Update CADIP/AUXIP helm configuration #53

Merged
merged 14 commits into from
Nov 22, 2024

Conversation

vprivat-ads
Copy link
Contributor

@vprivat-ads vprivat-ads commented Oct 23, 2024

Changes to test connection to real CADIP and ADGS stations:

  • remove unused stationConfigFile parameter
  • fix documentation
  • allow to configure OAuth2 token endpoint. It is not the same endpoint across all real CADIP stations
  • remove the need to configure individual OData endpoints: all CADIP stations implement the CADIP ICD with "/Files" and "/Sessions" endpoints. Only the root OData url needs to be configured (once).
  • change the session href mapping to use /Sessions endpoint instead of /Files

To use with RS-PYTHON/rs-server#687

@vprivat-ads vprivat-ads force-pushed the fix/cadip-updates branch 2 times, most recently from a7f7cdf to 4146a4a Compare October 24, 2024 15:21
@vprivat-ads vprivat-ads force-pushed the fix/cadip-updates branch 2 times, most recently from 05ea58d to be6dd9e Compare October 25, 2024 16:40
@vprivat-ads vprivat-ads changed the title Update CADIP helm configuration RSPY-491 + RSPY-492 + Update CADIP helm configuration Oct 28, 2024
@vprivat-ads vprivat-ads changed the title RSPY-491 + RSPY-492 + Update CADIP helm configuration RSPY-491 + RSPY-492 + RSPY-495 + Update CADIP helm configuration Nov 12, 2024
@vprivat-ads vprivat-ads changed the title RSPY-491 + RSPY-492 + RSPY-495 + Update CADIP helm configuration RSPY-491 + RSPY-492 + RSPY-495 + RSPY-506: Update CADIP/AUXIP helm configuration Nov 13, 2024
need_auth: true
results_entry: responses | $
results_entry: $.value
Copy link
Contributor

@jgaucher-cs jgaucher-cs Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgaucher-cs $.value everywhere. I probably forgot some cases

sort:
sort_by_tpl: '&$orderby={sort_param} {sort_order}'
sort_param_mapping:
startTimeFromAscendingNode: DownlinkStart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here @vprivat-ads, if I look at your two last changes in rs-server cadip config files:

  1. https://github.com/RS-PYTHON/rs-server/blob/d682b21d14402554c9320481c58929faacc34e17/services/cadip/config/cadip_ws_config.yaml
  2. https://github.com/RS-PYTHON/rs-server/blob/d682b21d14402554c9320481c58929faacc34e17/services/cadip/config/cadip_ws_config_token_module.yaml

The 3 fields:

        startTimeFromAscendingNode: DownlinkStart
        completionTimeFromAscendingNode: DownlinkStop
        publicationDate: PublicationDate

are defined only for the _session stations. But in this helm chart, you defined them for all stations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the "non session" stations, only publicationDate should be added, there is no downlinkStart/Stop info at file level, it's only at session level

@Padeanu Padeanu marked this pull request as ready for review November 22, 2024 07:22
@Padeanu Padeanu merged commit a6f79dd into develop Nov 22, 2024
2 checks passed
@vprivat-ads vprivat-ads deleted the fix/cadip-updates branch December 13, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants