Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSPY-491 - RSPY-492 - RSPY-495 - RSPY-506 - RSPY-507 - CADIP/AUXIP fixes #687

Merged
merged 36 commits into from
Nov 22, 2024

Conversation

vprivat-ads
Copy link
Contributor

@vprivat-ads vprivat-ads commented Nov 12, 2024

To use with RS-PYTHON/rs-helm#53

As stated in the tickets:

The following PR fixes the issues RSPY-491, RSPY-492, RSPY-495 (validated OK with real stations)

BUT the following activities remain to do:

  • fix pylint
  • update/fix unit tests
  • update/fix mockups
  • update/fix demo

@vprivat-ads vprivat-ads changed the title RSPY-491 - fix CADIP Session OData queries RSPY-491 - RSPY-492 - CADIP fixes Nov 12, 2024
@vprivat-ads vprivat-ads changed the title RSPY-491 - RSPY-492 - CADIP fixes RSPY-491 - RSPY-492 - RSPY-495 - CADIP fixes Nov 12, 2024
@vprivat-ads vprivat-ads force-pushed the fix/rspy491-cadip-search-fix-rebased-3 branch from 4a18fad to 7ed38b1 Compare November 12, 2024 14:36
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@vprivat-ads vprivat-ads force-pushed the fix/rspy491-cadip-search-fix-rebased-3 branch 2 times, most recently from 87ca5a6 to ffe2658 Compare November 13, 2024 13:57
@vprivat-ads vprivat-ads force-pushed the fix/rspy491-cadip-search-fix-rebased-3 branch from ffe2658 to abcfef9 Compare November 13, 2024 15:13
@vprivat-ads vprivat-ads changed the title RSPY-491 - RSPY-492 - RSPY-495 - CADIP fixes RSPY-491 - RSPY-492 - RSPY-495 - CADIP/AUXIP fixes Nov 13, 2024
@vprivat-ads vprivat-ads changed the title RSPY-491 - RSPY-492 - RSPY-495 - CADIP/AUXIP fixes RSPY-491 - RSPY-492 - RSPY-495 - RSPY-506 - RSPY-507 - CADIP/AUXIP fixes Nov 15, 2024
…n' into fix/rspy491-cadip-search-fix-rebased-3
#platform: platformSerialIdentifier
#constellation: platformShortName
#processing:facility: processingCenter
startTimeFromAscendingNode: ContentDate.Start
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake it's a slash: ContentDate/Start. I do the remark only once but there are more occurrences to fix

#constellation: platformShortName
#processing:facility: processingCenter
startTimeFromAscendingNode: ContentDate.Start
completionTimeFromAscendingNode: ContentDate.Stop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake it's a slash: ContentDate/Stop. I do the remark only once but there are more occurrences to fix

@@ -101,7 +101,7 @@ adgs:
free_text_search_operations:
$filter:
union: ' OR '
wrapper: '{}'
wrapper: '"{}"'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it must be without quotes. I do the remark only once but there are more occurrences to fix

@Padeanu Padeanu marked this pull request as ready for review November 20, 2024 15:01
@Padeanu Padeanu added bug Something isn't working bugfix Some know issues fixed and removed bug Something isn't working labels Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

SonarQube Quality Gate Result

  • Result: ✅ OK
  • Branch: 687/merge
  • Triggered by @Padeanu on pull_request
Metric Status Value Error Threshold
New reliability rating ✅ OK 1 > 1
New security rating ✅ OK 1 > 1
New maintainability rating ✅ OK 1 > 1
New coverage ✅ OK 100 < 80
New duplicated lines density ✅ OK 0 > 3

View on SonarQube

updated: 11/21/2024, 16:50:51 (UTC+0)

Copy link

@Padeanu Padeanu merged commit 39a1d7c into develop Nov 22, 2024
31 of 33 checks passed
@jgaucher-cs jgaucher-cs deleted the fix/rspy491-cadip-search-fix-rebased-3 branch November 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Some know issues fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants