Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ledger clear signing #2661

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

heisenberg-2077
Copy link
Contributor

No description provided.

@vvvvvv1vvvvvv vvvvvv1vvvvvv merged commit a88a0dc into develop Dec 6, 2024
9 checks passed
@vvvvvv1vvvvvv vvvvvv1vvvvvv deleted the fix/remove-clear-signing branch December 6, 2024 08:17
@0x398
Copy link

0x398 commented Dec 7, 2024

Guys, really? Why you remove clear signing again? Can you actually fix issues rather than remove clear signing everytime? At least mention this in release notes. Such a huge regression not mentioned in release notes!

@AdamB2023
Copy link

This is damn crazy and regression of security. Why you did it at all?

@0x398
Copy link

0x398 commented Dec 7, 2024

@vvvvvv1vvvvvv @heisenberg-2077 Or make at least an option whether user wants to use clear signing! If you do not care about security, does not mean everybody is as careless as you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants