Quota error handling on bdp request #400
Conversation
src/bdp.cpp
Outdated
|
|
||
| namespace { | ||
| const bbg::Name RESPONSE_ERROR("responseError"); | ||
| } |
There was a problem hiding this comment.
This looks a little verbose and out of sync with the rest, Could this not have been done via the existing using BloombergLP::blpapi::Name; from line 45 along with
const Name Response_Error("responseError");inside the function?
There was a problem hiding this comment.
@johnlaing Can you maybe take a look on your end too?
There was a problem hiding this comment.
I looked at what was done in getTicks/getBars but yes it is not exactly the same thing in this part of code.
There was a problem hiding this comment.
That looks better.
@johnlaing Would be great if you could give the pr a spin as well.
RodolpheDuge
force-pushed
the
master
branch
2 times, most recently
from
9d35d33 to
fb2fbef
Compare
There was a problem hiding this comment.
Oh, one more thing: Can you please commit an entry to ChangeLog? The format is 'date two spaces name two spaces email' and the entries have a eight spaces (or a tab) followed by '* path/file/changed.txt: Summary of what changed' which is likely a one liner here, and have an empty line above and below. Emacs automates that with C-x 4 a if you happen to use it.
| 2024-11-25 Rodolphe Duge <[email protected]> | ||
|
|
||
| * src/bdp.c: Quota error handling on bdp request | ||
|
|
When doing a bdp request, we can receive an error message (quota ...)
in the result which gives the following error message:
Choice sub-element not found for name 'securityData'.
Log the received message and throw an exception to have a clearer error message.