This repository has been archived by the owner on Mar 1, 2025. It is now read-only.
fixed completion date error msg for falsy start date #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shubhamsinghbundela
approved these changes
Oct 22, 2023
iamitprakash
approved these changes
Oct 23, 2023
iamitprakash
pushed a commit
that referenced
this pull request
Oct 26, 2023
This was referenced Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #562
What is the change?
Design Doc: https://docs.google.com/document/d/1JvBDR9Kfo0pzfl-fM7tLZO7WmmRAWbCVFNDgHqnos1k/edit?usp=sharing
If "startedOn" key is falsy i.e undefined/null/0 then completion date should show as 'N/A', so updated timeWas fn to handle this case.
Is it bug?
Yes
Steps to repro
Go to https://members.realdevsquad.com/amitprakash any member profile and you will see some contribution/task where completion date is NAN sec or 54 years which is invalid.
Expected
Actual
*Dev Tested?
*Tested on:
Platforms
Browsers
Before / After Change Screenshots
Before
After
Test results: