feat: enhance add_filter to support the max matched lines #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It depends on #4299. Please do not review it yet. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4303 +/- ##
=======================================
Coverage 76.97% 76.98%
=======================================
Files 735 735
Lines 41300 41306 +6
Branches 8770 8772 +2
=======================================
+ Hits 31791 31799 +8
Misses 8441 8441
+ Partials 1068 1066 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
force-pushed
the
add_filter_with_count
branch
3 times, most recently
from
d670896 to
6282e36
Compare
xiangce
force-pushed
the
add_filter_with_count
branch
6 times, most recently
from
776f4e4 to
81aba8c
Compare
- added a new keyword argument "max_match=MAX_MATCH" to `add_filter`. By declaring the max_match, at most `max_match` number of lines that contain the patterns will be filtered out in the collection. For redundant declarations the maximum `max_match` will be kept as the final scanning number. If no `max_match` is declared when `add_filter`, the filters.MAX_MATCH (=10000) will be take as the default value. - added a new keyword argument "with_matches=False" to the `get_filters`. When "with_matches=True" is specified, the return value of the `get_filters` will be dict in which the max scanning numbers for each filter pattern are included as the dict value. - update the exiting tests - RHINENG-14669 Signed-off-by: Xiangce Liu <[email protected]>
xiangce
force-pushed
the
add_filter_with_count
branch
from
81aba8c to
02c9dbb
Compare
|
test me |
JoySnow
reviewed
Jan 2, 2025
xiangce
force-pushed
the
add_filter_with_count
branch
2 times, most recently
from
dde8128 to
e46cab8
Compare
Signed-off-by: Xiangce Liu <[email protected]>
xiangce
force-pushed
the
add_filter_with_count
branch
from
e46cab8 to
8e03f6a
Compare
JoySnow
approved these changes
Jan 3, 2025
|
I confirmed with perf-scale team, and got that these CPT jenkins failures were caused by Jenkins migration is still WIP, the same test on old jenkins are passed see https://master-jenkins-csb-perf.apps.ocp-c1.prod.psi.redhat.com/job/InsightsInsightsCore_runner/ And this PR also got PASS in the verification on QE end see RHINENG-15025 Merging it. |
xiangce
added a commit
that referenced
this pull request
Jan 9, 2025
- added a new keyword argument "max_match=MAX_MATCH" to `add_filter`. By declaring the max_match, at most `max_match` number of lines that contain the patterns will be filtered out in the collection. For redundant declarations the maximum `max_match` will be kept as the final scanning number. If no `max_match` is declared when `add_filter`, the filters.MAX_MATCH (=10000) will be taken as the default value. - added a new keyword argument "with_matches=False" to the `get_filters`. When "with_matches=True" is specified, the return value of the `get_filters` will be dict in which the max scanning numbers for each filter pattern are included as the dict value. - update the exiting tests - RHINENG-14669 Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit 9c64871)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_filter.By declaring the max_match, at most
max_matchnumber of lines thatcontain the patterns will be filtered out in the collection.
For redundant declarations the maximum
max_matchwill be kept as thefinal scanning number. If no
max_matchis declared whenadd_filter,the filters.MAX_MATCH (=10000) will be take as the default value.
get_filters.When "with_matches=True" is specified, the return value of the
get_filterswill be dict in which the max scanning numbers for eachfilter pattern are included as the dict value.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here