Fix fw security #4312
Closed
Fix fw security #4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiaoxue Wang <[email protected]>
Signed-off-by: Xiaoxue Wang <[email protected]>
Signed-off-by: Xiaoxue Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4312 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 765 765
Lines 41753 41764 +11
Branches 8815 8819 +4
=======================================
+ Hits 32221 32232 +11
- Misses 8464 8465 +1
+ Partials 1068 1067 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
reviewed
Dec 19, 2024
| @@ -123,13 +123,21 @@ class FwupdagentDevices(CommandParser, JSONParser): | |||
| >>> len(devices["Devices"]) | |||
| 2 | |||
| """ | |||
| pass | |||
| def _handle_content(self, context): | |||
There was a problem hiding this comment.
It looks not a good idea to cut the content in the _handle_content level. Why not re-implement it in parse_content?
xiangce
reviewed
Dec 19, 2024
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
RHINENG-14570