Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the collection of unused spec fw_devices #4318

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

JoySnow
Copy link
Collaborator

@JoySnow JoySnow commented Dec 20, 2024

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

RHINENG-14570

resolve part of #4312

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (952f219) to head (edda1bd).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4318   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         765      765           
  Lines       41753    41769   +16     
  Branches     8815     8821    +6     
=======================================
+ Hits        32221    32237   +16     
  Misses       8464     8464           
  Partials     1068     1068           
Flag Coverage Δ
unittests 77.16% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoySnow JoySnow requested a review from xiangce December 20, 2024 06:07
@JoySnow JoySnow mentioned this pull request Dec 20, 2024
4 tasks
@xiangce xiangce merged commit 3474a94 into RedHatInsights:master Dec 23, 2024
15 of 16 checks passed
@JoySnow JoySnow deleted the retire-spec-fw_devices branch December 23, 2024 05:30
xiangce pushed a commit that referenced this pull request Jan 2, 2025
- RHINENG-14570

Signed-off-by: Xiaoxue Wang <[email protected]>
(cherry picked from commit 3474a94)
xiangce pushed a commit that referenced this pull request Jan 2, 2025
- RHINENG-14570

Signed-off-by: Xiaoxue Wang <[email protected]>
(cherry picked from commit 3474a94)
(cherry picked from commit 64ba3f4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants