fix(client): Serialize properly escape characters #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4335 +/- ##
=======================================
Coverage 77.03% 77.03%
=======================================
Files 736 736
Lines 41369 41374 +5
Branches 8789 8790 +1
=======================================
+ Hits 31869 31874 +5
Misses 8438 8438
Partials 1062 1062
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
added
the
client
* Card ID: CCT-1065 Backslashes in regex patterns were not properly escaped, causing inconsistencies between Fedora 40 and CentOS Stream 9 environments. This commit ensures that all escape characters are properly serialized. Signed-off-by: pkoprda <[email protected]>
@m-horky, Yes you are right. These Jenkins are still WIP, @zhangqianqian is working on it. Let's ignore them for now. Sorry for the inconvenience. I'm going to merge the PR. |
xiangce
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Card ID: CCT-1065 Backslashes in regex patterns were not properly escaped, causing inconsistencies between Fedora 40 and CentOS Stream 9 environments. This commit ensures that all escape characters are properly serialized. Signed-off-by: pkoprda <[email protected]> (cherry picked from commit f8451aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Backslashes in regex patterns were not properly escaped, causing inconsistencies between Fedora 40 and CentOS Stream 9 environments. This commit ensures that all escape characters are properly serialized.
This pull request is a backport from insights-ansible-playbook-verifier#27