refact(RHINENG-15309): Refactor filtering logic related to custom staleness #2183
Conversation
| @@ -12,6 +12,7 @@ | |||
| PRODUCER_ACKS = {"0": 0, "1": 1, "all": "all"} | |||
|
|
|||
| HOST_TYPES = ["edge", None] | |||
| ALL_STALENESS_STATES = ("fresh", "stale", "stale_warning") | |||
There was a problem hiding this comment.
Is there a no possibility of checking "culled" state?
There was a problem hiding this comment.
All I'm doing is moving this constant from host_repository.py to config.py, not changing any values. But no, we don't allow querying hosts that are in the culled state
There was a problem hiding this comment.
I think it is needed so I filed RHINENG-15328.
| @@ -170,6 +180,21 @@ def _staleness_filter( | |||
| return [or_(*staleness_conditions)] | |||
|
|
|||
|
|
|||
| def staleness_to_conditions( | |||
| staleness, staleness_states, host_type, timestamp_filter_func, omit_host_type_filter: bool = False | |||
There was a problem hiding this comment.
should stick with one name staleness_states or staleness_type? The caller calls it type but the argument uses states; unnecessary change.
There was a problem hiding this comment.
This function is retaining the same signature as what it had when it was in culling.py.
Also, I don't see staleness_type used anywhere; can you please point me to that?
There was a problem hiding this comment.
oh it was staleness_types on line 206, 207, and 228 in lib/host_repository.py
Overview
This PR is being created to address RHINENG-15309.
The purpose of this PR is to simplify some things, but it also resolves an inconsistency with staleness_to_conditions, which is needed to unblock #2181.
PR Checklist
Secure Coding Practices Documentation Reference
You can find documentation on this checklist here.
Secure Coding Checklist