Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting: move fixtures to conftest.py #341

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

Glutexo
Copy link
Collaborator

@Glutexo Glutexo commented Jul 11, 2019

Moved fixtures from the test_utils module to a special conftest.py file that is grabbed automatically by pytest. This fixes the F811 Flake8 rule complaining about test function argument names clashing with the pytest fixture function name.

This is a part of the first step to fix all the formatting. See #189, #335 and #331.

@Glutexo Glutexo self-assigned this Jul 11, 2019
@Glutexo Glutexo mentioned this pull request Jul 11, 2019
@Glutexo Glutexo changed the title Fix F811 rule, move fixtures to conftest.py Formatting: move fixtures to conftest.py Jul 11, 2019
Moved fixtures from test_utils module to a special conftest.py file that
is grabbed automatically by pytest. This fixes the F811 Flake8 rule
complaining about test function argument names clashing with the pytest
fixture function name.
@Glutexo
Copy link
Collaborator Author

Glutexo commented Jul 17, 2019

Rebased and mergeable again. This was a genuine conflict as there has been added a #noqa comment as a temporary solution and this one fixes the same line properly. 🙂

@dehort dehort merged commit 0310263 into RedHatInsights:master Jul 17, 2019
@Glutexo Glutexo deleted the flake8_fixtures branch July 18, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants