Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template-ref for pd-connect to use latest in PR tests #357

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

josejulio
Copy link
Member

What?

Explain what the change is linking any relevant JIRAs or Issues.

Why?

Consider what business or engineering goal does this PR achieves.

How?

Describe how the change is implemented. Any noteable new libaries, APIs, or features.

Testing

Did you add any tests for the change?

Anything Else?

Any other notes about the PR that would be useful for the reviewer.

Secure Coding Practices Checklist Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@josejulio josejulio marked this pull request as ready for review March 26, 2024 16:58
@josejulio josejulio changed the title Remove template-ref for pd-connect in PR tests Update template-ref for pd-connect to use latest in PR tests Mar 26, 2024
pr_check.sh Outdated Show resolved Hide resolved
pr_check.sh Show resolved Hide resolved
Copy link
Contributor

@dehort dehort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@tahmidefaz tahmidefaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🤞

@josejulio josejulio merged commit 8bd75c5 into master Mar 27, 2024
12 of 14 checks passed
@josejulio josejulio deleted the josejulio-patch-1 branch March 27, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants