Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template-ref for pd-connect to use latest in PR tests #357

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Update template-ref for pd-connect to use latest in PR tests #357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
286aaaf
Remove template-ref for pd-connect in PR tests
josejulio Mar 26, 2024
20949cc
Apply suggestions from code review
josejulio Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pr_check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ source $CICD_ROOT/build.sh

# IMAGE is set to the Connect image, setting dispatcher image as an extra arg
# hardcode connect to use a ref that works in ephemeral
EXTRA_DEPLOY_ARGS="--set-image-tag ${IMAGE_DISPATCHER}=${IMAGE_TAG} --set-template-ref ${CONNECT_COMPONENT_NAME}=709963354a31225591dd612f15c670a14ddf3c99"
EXTRA_DEPLOY_ARGS="--set-image-tag ${IMAGE_DISPATCHER}=${IMAGE_TAG} --set-template-ref ${CONNECT_COMPONENT_NAME}=${GIT_COMMIT}"

# Deploy to an ephemeral environment
source $CICD_ROOT/deploy_ephemeral_env.sh
Expand All @@ -48,7 +48,7 @@ bonfire deploy playbook-dispatcher cloud-connector \
--set-template-ref ${COMPONENT_NAME}=${GIT_COMMIT} \
--set-image-tag ${IMAGE_DISPATCHER}=${IMAGE_TAG} \
--set-image-tag ${IMAGE_CONNECT}=${IMAGE_TAG} \
--set-template-ref ${CONNECT_COMPONENT_NAME}=047e256da507f29d0e0ae803a4b1d688eb74a2cb \
--set-template-ref ${CONNECT_COMPONENT_NAME}=${GIT_COMMIT} \
--namespace ${NAMESPACE} \
josejulio marked this conversation as resolved.
Show resolved Hide resolved
--timeout ${DEPLOY_TIMEOUT} \
--set-parameter playbook-dispatcher/CLOUD_CONNECTOR_IMPL=impl
Expand Down
Loading