SWATCH-3152: Configure swatch-producer-azure to skip bad messages #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wottop
force-pushed
the
wottop/SWATCH-3152
branch
from
2eb4226 to
bbbf41a
Compare
wottop
force-pushed
the
wottop/SWATCH-3152
branch
from
bbbf41a to
5747d62
Compare
wottop
changed the title
|
/retest |
|
/retest |
1 similar comment
|
/retest |
Sgitario
reviewed
Jan 15, 2025
| @@ -10,7 +10,7 @@ SPLUNK_HEC_BATCH_SIZE=1000 | |||
| SPLUNK_HEC_BATCH_INTERVAL=10S | |||
| SPLUNK_HEC_RETRY_COUNT=3 | |||
| SPLUNK_HEC_INCLUDE_EX=true | |||
| USAGE_AGGREGATE_FAIL_ON_DESER_FAILURE=true | |||
| USAGE_AGGREGATE_FAIL_ON_DESER_FAILURE=false | |||
There was a problem hiding this comment.
why do we need to disable this?
There was a problem hiding this comment.
It is used in line 112:
mp.messaging.incoming.billable-usage-hourly-aggregate-in.fail-on-deserialization-failure=${USAGE_AGGREGATE_FAIL_ON_DESER_FAILURE}
Without this setting, bad json kills the pod
There was a problem hiding this comment.
Didn't know about this behaviour. We can read more information in https://es.quarkus.io/guides/kafka#handling-deserialization-failures.
Thanks!
wottop
added
QE
Sgitario
approved these changes
Jan 15, 2025
Sgitario
added
Dev/approved
|
/retest |
1 similar comment
|
/retest |
liwalker-rh
approved these changes
Jan 16, 2025
liwalker-rh
added
QE/approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: SWATCH-3152
Description
Testing
IQE Test MR:
MR 987
Setup
Steps
Verification