Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWATCH-3152: Configure swatch-producer-azure to skip bad messages #4104

Merged
merged 1 commit into from
Jan 16, 2025
Merged

SWATCH-3152: Configure swatch-producer-azure to skip bad messages #4104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion swatch-producer-azure/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ SPLUNK_HEC_BATCH_SIZE=1000
SPLUNK_HEC_BATCH_INTERVAL=10S
SPLUNK_HEC_RETRY_COUNT=3
SPLUNK_HEC_INCLUDE_EX=true
USAGE_AGGREGATE_FAIL_ON_DESER_FAILURE=true
USAGE_AGGREGATE_FAIL_ON_DESER_FAILURE=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to disable this?

Copy link
Contributor Author

@wottop wottop Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used in line 112:
mp.messaging.incoming.billable-usage-hourly-aggregate-in.fail-on-deserialization-failure=${USAGE_AGGREGATE_FAIL_ON_DESER_FAILURE}

Without this setting, bad json kills the pod

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about this behaviour. We can read more information in https://es.quarkus.io/guides/kafka#handling-deserialization-failures.
Thanks!

WIREMOCK_ENDPOINT=http://wiremock-service:8000
CORS_ORIGINS=/.+\\\\.redhat\\\\.com/
DISABLE_OTEL=true
Expand Down Expand Up @@ -113,6 +113,7 @@ mp.messaging.incoming.billable-usage-hourly-aggregate-in.fail-on-deserialization
mp.messaging.incoming.billable-usage-hourly-aggregate-in.connector=smallrye-kafka
mp.messaging.incoming.billable-usage-hourly-aggregate-in.topic=platform.rhsm-subscriptions.billable-usage-hourly-aggregate
mp.messaging.incoming.billable-usage-hourly-aggregate-in.group.id=swatch-producer-azure-usage-aggregate-consumer
mp.messaging.incoming.billable-usage-hourly-aggregate-in.failure-strategy=ignore
# Start at end of topic to prevent duplicate billing
mp.messaging.incoming.billable-usage-hourly-aggregate-in.auto.offset.reset=earliest
# This value needs to be synced with the retry configuration of the contracts API which will retry up to
Expand Down
Loading