Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always split response type #2225

Merged
merged 10 commits into from
Dec 2, 2024
Merged

Always split response type #2225

merged 10 commits into from
Dec 2, 2024
+566 −498

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Dec 1, 2024 •
edited
Loading

Partially based on discussion #2219
Needed for #2226
But generally should simplify the flow and enable further improvements of the Integration class

@RobinTail RobinTail added enhancement New feature or request refactoring The better way to achieve the same result labels Dec 1, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Dec 1, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 210cc19 on always-split-response
into fea1f88 on master.

@RobinTail RobinTail mentioned this pull request Dec 1, 2024
Draft
@RobinTail RobinTail changed the title Exp: always split response type Always split response type Dec 1, 2024
@RobinTail RobinTail added the documentation Improvements or additions to documentation label Dec 1, 2024
@RobinTail RobinTail marked this pull request as ready for review December 1, 2024 20:18
RobinTail
RobinTail commented Dec 1, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@RobinTail RobinTail changed the title Always split response type Exp: Always split response type Dec 2, 2024
@RobinTail RobinTail marked this pull request as draft December 2, 2024 07:48
@RobinTail RobinTail changed the title Exp: Always split response type Always split response type Dec 2, 2024
@RobinTail RobinTail marked this pull request as ready for review December 2, 2024 11:01
@RobinTail
Copy link
Owner Author

✅ QA passed

@RobinTail RobinTail merged commit d8b105e into master Dec 2, 2024
12 checks passed
@RobinTail RobinTail deleted the always-split-response branch December 2, 2024 11:21
@RobinTail RobinTail mentioned this pull request Dec 2, 2024
Merged
RobinTail added a commit that referenced this pull request Dec 2, 2024
@RobinTail
Remove redundant Partial<> from Integration::registry (#2232)
cb1f01e 
Due to #2225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail