Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exp: Splitting response further to the status codes #2226

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

Exp: Splitting response further to the status codes #2226

wants to merge 29 commits into from
+676 −130

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Dec 1, 2024 •
edited
Loading

Should go after #2225
And probably in v22

Based on discussion #2219

@RobinTail RobinTail added the enhancement New feature or request label Dec 1, 2024
@RobinTail RobinTail added this to the v22 milestone Dec 1, 2024
@RobinTail RobinTail changed the title Splitting positive response further to the status codes. Splitting response further to the status codes Dec 1, 2024
@RobinTail RobinTail mentioned this pull request Dec 1, 2024
Merged
@RobinTail
Copy link
Owner Author

I'm not sure it would allow making status code operating client.
It would require a single 3-dimensional dictionary-like interface.

@RobinTail RobinTail changed the title Splitting response further to the status codes Exp: Splitting response further to the status codes Dec 2, 2024
RobinTail added a commit that referenced this pull request Dec 2, 2024
@RobinTail
Always split response type (#2225)
d8b105e 
Partially based on discussion
#2219
Needed for #2226 
But generally should simplify the flow and enable further improvements
of the Integration class
Base automatically changed from always-split-response to master December 2, 2024 11:21
@RobinTail RobinTail mentioned this pull request Dec 2, 2024
Draft
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Dec 2, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 911e185 on emphasise-status-code
into cb1f01e on master.

@RobinTail RobinTail mentioned this pull request Dec 2, 2024
Merged
RobinTail added a commit that referenced this pull request Dec 2, 2024
@RobinTail
makeKeyOf() helper (#2231)
e0f0932 
Will reuse in #2214 and #2226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v22
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail