Update rcfile advice for force_pic and disable it by default #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+@rpoyner-tri for feature review, please. N.B. The current CI failure is a known issue (also broken on |
|
This can be rebased now with #271 in and CI should pass ™️ |
While we're here, clean up some other non-functional irregularies: - Remove irrelevant rules_python flag. - Use the correct working directory during `bazel version`.
jwnimmer-tri
force-pushed
the
no-force-pic
branch
from
5744d7f to
5881e86
Compare
rpoyner-tri
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [rpoyner-tri] (waiting on @jwnimmer-tri)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're here, clean up some other non-functional irregularies:
bazel version.Towards RobotLocomotion/drake#20217.
See also RobotLocomotion/drake#20242.
This change is