Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rcfile advice for force_pic and disable it by default #270

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Update rcfile advice for force_pic and disable it by default #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions drake_bazel_external/.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
# SPDX-License-Identifier: MIT-0

# Disable native Python rules in Bazel versions before 3.0.
build --incompatible_load_python_rules_from_bzl=yes

# Default to an optimized build.
build --compilation_mode=opt

# Default build options.
build --force_pic=yes
build --strip=never

# Default test options.
Expand All @@ -21,6 +17,11 @@ build --host_cxxopt=-std=c++17
# https://github.com/bazelbuild/bazel/issues/1164
build --action_env=CCACHE_DISABLE=1

# For Ubuntu builds, this flag can cut build times in half. For macOS builds,
# this flag might cause build errors. We suggest turning it on if and only if
# your project doesn't use macOS.
## build --force_pic=yes

# TODO(jwnimmer-tri) We should see if we can reuse more of Drake's
# customizations somehow.

Expand Down
10 changes: 5 additions & 5 deletions drake_bazel_installed/.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
# SPDX-License-Identifier: MIT-0

# Disable native Python rules in Bazel versions before 3.0.
# TODO(jamiesnape): Uncomment the below line when @drake uses @rules_python.
# build --incompatible_load_python_rules_from_bzl=yes

# Default to an optimized build.
build --compilation_mode=opt

# Default build options.
build --force_pic=yes
build --strip=never

# Default test options.
Expand All @@ -22,6 +17,11 @@ build --host_cxxopt=-std=c++17
# https://github.com/bazelbuild/bazel/issues/1164
build --action_env=CCACHE_DISABLE=1

# For Ubuntu builds, this flag can cut build times in half. For macOS builds,
# this flag might cause build errors. We suggest turning it on if and only if
# your project doesn't use macOS.
## build --force_pic=yes

# TODO(jwnimmer-tri) We should see if we can reuse more of Drake's
# customizations somehow.

Expand Down
3 changes: 1 addition & 2 deletions scripts/continuous_integration/common/drake_bazel_external
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@

set -euxo pipefail

bazel version

pushd drake_bazel_external

bazel version
bazel test //...

popd
3 changes: 1 addition & 2 deletions scripts/continuous_integration/common/drake_bazel_installed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@

set -euxo pipefail

bazel version

pushd drake_bazel_installed

bazel version
bazel test //...

popd
Loading