Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GHA ci #320

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

nicolecheetham
Copy link
Collaborator

@nicolecheetham nicolecheetham commented Sep 30, 2024

Refactor GHA ci workflow so the main ci implements reusable workflows found in the root .github directory.

Issue: #309


This change is Reviewable

@nicolecheetham nicolecheetham marked this pull request as draft September 30, 2024 13:56
@nicolecheetham nicolecheetham force-pushed the dee_examples_ci branch 2 times, most recently from a9c7e1e to 4d04625 Compare October 17, 2024 18:59
@nicolecheetham nicolecheetham changed the title Add example specific GHA CIs Refactor GHA ci Oct 23, 2024
@nicolecheetham nicolecheetham marked this pull request as ready for review October 23, 2024 17:29
Copy link
Collaborator Author

@nicolecheetham nicolecheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri for feature review please

Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @jwnimmer-tri)

@nicolecheetham
Copy link
Collaborator Author

How does the renaming of the jobs look? Moreover, what did you mention regarding the creation of ci copies within each respective example dir?

Copy link
Contributor

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Moreover, what did you mention regarding the creation of ci copies within each respective example dir?

Remind me to post an example again, after this merges.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [jwnimmer-tri] (waiting on @nicolecheetham)

Copy link
Collaborator Author

@nicolecheetham nicolecheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sammy-tri for platform review please

Reviewable status: all discussions resolved, LGTM missing from assignee sammy-tri, platform LGTM from [jwnimmer-tri] (waiting on @sammy-tri)

@jwnimmer-tri
Copy link
Contributor

I'll cover both reviews here.

@jwnimmer-tri jwnimmer-tri merged commit 943a33a into RobotLocomotion:main Oct 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants