-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GHA ci #320
Refactor GHA ci #320
Conversation
a9c7e1e
to
4d04625
Compare
1a390aa
to
e7d8e21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@jwnimmer-tri for feature review please
Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @jwnimmer-tri)
How does the renaming of the jobs look? Moreover, what did you mention regarding the creation of ci copies within each respective example dir? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover, what did you mention regarding the creation of ci copies within each respective example dir?
Remind me to post an example again, after this merges.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all discussions resolved, platform LGTM from [jwnimmer-tri] (waiting on @nicolecheetham)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@sammy-tri for platform review please
Reviewable status: all discussions resolved, LGTM missing from assignee sammy-tri, platform LGTM from [jwnimmer-tri] (waiting on @sammy-tri)
I'll cover both reviews here. |
Refactor GHA ci workflow so the main ci implements reusable workflows found in the root .github directory.
Issue: #309
This change is