[drake_cmake_external] Strenthen CI by removing unnecessary prereqs #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
force-pushed
the
cmake_external-narrow-deps
branch
from
bdf980b to
bd03d4b
Compare
|
+@rpoyner-tri for both reviews, please. |
rpoyner-tri
approved these changes
Dec 21, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [rpoyner-tri] (waiting on @jwnimmer-tri)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help ensure that the CMake changes in RobotLocomotion/drake#22338 do not break downstream users, by ensuring that the only copies of {eigen, fmt, spdlog} on the CI machine are the custom ones built by CMake and found with
find_package-- if the CMake plumbing doesn't work, then the example will fail to compile.Towards RobotLocomotion/drake#20731.
This change is