Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be possible to provide sdf/urdf models as strings #12754

Closed
ggould-tri opened this issue Feb 20, 2020 · 6 comments
Closed

Should be possible to provide sdf/urdf models as strings #12754

ggould-tri opened this issue Feb 20, 2020 · 6 comments

Comments

@ggould-tri
Copy link
Contributor

Currently the only way to add SDF/URDF models to a MultibodyPlant is via AddModelFromFile. However there are cases where a model is more easily provided in the form of a string or a stream. For example @avalenzu notes that a DRC team had the robot provide its model over the wire, and I am currently working with a robot (WLKATA Mirobot) that emits the link data used in its internal IK via its serial protocol.

It would probably make sense to provide AddModelFromStream and a trivial wrapper around that for AddModelFromString.

@jwnimmer-tri
Copy link
Collaborator

The libsdformat APIs don't really support streaming, so I just plan to add a string overload directly.

@SeanCurtis-TRI
Copy link
Contributor

@jwnimmer-tri I have a branch where I started this as well. Are you actively tackling this? I note you elevated the priority. Depending on how far along you are, I can either finish mine or retire it.

@SeanCurtis-TRI
Copy link
Contributor

Never mind; I just noticed the PR.

@EricCousineau-TRI
Copy link
Contributor

FWIW Semi-relates #9500 (stuff on the wire, etc)

@jwnimmer-tri
Copy link
Collaborator

I added AddModelFromString but not the plural AddAllModelsFromString companion. I'll reopen the issue (at lower priority) to go back and add that, too.

@rpoyner-tri
Copy link
Contributor

Is there a reason this issue is still open? the String APIs have been available for quite some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants