Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parsing] Better error logging from package_downloader #19047

Closed
jwnimmer-tri opened this issue Mar 21, 2023 · 0 comments · Fixed by #19081
Closed

[parsing] Better error logging from package_downloader #19047

jwnimmer-tri opened this issue Mar 21, 2023 · 0 comments · Fixed by #19081
Assignees
Labels

Comments

@jwnimmer-tri
Copy link
Collaborator

In #18955, we have package_map.AddRemote(....) now, so calling package_map.GetPath("...") can sometimes kick off a download.

Because of the way it's implemented, if the downloader fails then the details of the error (e.g., "dns is broken") go to stderr -- our spdlog only gets a generic "download failed" message. See review thread for extra details.

We should be able to change the downloader to write its error message to a json file, and then have package_map.cc copy that back into spdlog.

@jwnimmer-tri jwnimmer-tri added type: bug component: multibody parsing Loading models into MultibodyPlant labels Mar 21, 2023
@jwnimmer-tri jwnimmer-tri self-assigned this Mar 21, 2023
@jwnimmer-tri jwnimmer-tri changed the title package_downloader error logging [parsing] Better error logging from package_downloader Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant