Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visualization_install_tests vs macOS python3.12 upgrade #21023

Open
jwnimmer-tri opened this issue Feb 22, 2024 · 6 comments
Open

visualization_install_tests vs macOS python3.12 upgrade #21023

jwnimmer-tri opened this issue Feb 22, 2024 · 6 comments
Assignees
Labels
component: continuous integration Jenkins, CDash, mirroring of externals, website infrastructure priority: low type: bug

Comments

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Feb 22, 2024

The visualization_install_tests are somewhat brittle w.r.t. how we choose macOS python versions.

For now, I'm going to disable them on macOS to unbreak CI.

The problem is that the installed programs use the shebang line #!/usr/bin/env python3, which in Unprovisioned macOS builds is not /opt/homebrew/bin/python3.11 but something else ... maybe Apple Python? Anyway, it doesn't work.

Probably to fix these tests, we need to set a $PATH with a magic symlink to sys.executable.

@jwnimmer-tri
Copy link
Collaborator Author

@mwoehlke-kitware with the venv, I believe we can probably revert the #21024 now. Could you give it a try?

CC @BetsyMcPhail

@nicolecheetham
Copy link
Contributor

The mac job for the PR made to revert this one fails. Therefore it will be closed.
PR link: #22174

@jwnimmer-tri
Copy link
Collaborator Author

It doesn't make any sense why Provisioned and Unprovisioned jobs would have a different result. That needs some investigation.

@jwnimmer-tri
Copy link
Collaborator Author

It doesn't make any sense why Provisioned and Unprovisioned jobs would have a different result. That needs some investigation.

Specifically, the PR does not change any setup/... code, it only runs a couple of extra test cases. Having different CI results for Provisioned and Unprovisioned in the absence of setup changes indicates that the current Provisioned image snapshot has somehow diverged from what would happen if we were to make a new snapshot today.

It may very well be that this issue is still unfixed and the test cases are true positive failures, indicating that we need further changes to our code. However, we should first understand why the provisioned snapshot seems to be inauthentic, before proceeding further.

@nicolecheetham
Copy link
Contributor

In both of the unprovisioned job attempts there was a failure with //:py/install_test. In addition they mention a failed result of
pydrake/visualization/test/visualization_install_tests.py. However, in both provisioned jobs there is no mention of running pydrake/visualization/test/visualization_install_tests.py let alone fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: continuous integration Jenkins, CDash, mirroring of externals, website infrastructure priority: low type: bug
Development

No branches or pull requests

4 participants