Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ycb] Move related Drake files into here #42

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Mar 25, 2024

This were copied from Drake as of 1d54460b.

Twin PR: RobotLocomotion/drake#21190


This change is Reviewable

This were copied from Drake as of 1d54460b.
@jwnimmer-tri
Copy link
Contributor Author

+@SeanCurtis-TRI for both reviews, please (load balancing Rico).

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM: X2

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM missing (waiting on @jwnimmer-tri)


-- commits line 4 at r1:
nit: typo

Suggestion:

These

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(BTW, Apparently I don't have platform review powers over here.)

Reviewable status: 1 unresolved discussion, platform LGTM missing (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Contributor Author

(BTW, Apparently I don't have platform review powers over here.)

Fixed.

Copy link
Contributor Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [seancurtis-tri] (waiting on @jwnimmer-tri)


-- commits line 4 at r1:

Previously, SeanCurtis-TRI (Sean Curtis) wrote…

nit: typo

Will fix during squashing.

@jwnimmer-tri jwnimmer-tri merged commit c18b846 into RobotLocomotion:master Mar 25, 2024
2 checks passed
@jwnimmer-tri jwnimmer-tri deleted the ycb branch March 25, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants