-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ycb] Move related Drake files into here #42
Conversation
This were copied from Drake as of 1d54460b.
+@SeanCurtis-TRI for both reviews, please (load balancing Rico). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM missing (waiting on @jwnimmer-tri)
-- commits
line 4 at r1:
nit: typo
Suggestion:
These
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(BTW, Apparently I don't have platform review powers over here.)
Reviewable status: 1 unresolved discussion, platform LGTM missing (waiting on @jwnimmer-tri)
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all discussions resolved, platform LGTM from [seancurtis-tri] (waiting on @jwnimmer-tri)
Previously, SeanCurtis-TRI (Sean Curtis) wrote…
nit: typo
Will fix during squashing.
This were copied from Drake as of
1d54460b
.Twin PR: RobotLocomotion/drake#21190
This change is